[Workload-Orchestration] Added Context-ID in Target Update#8977
[Workload-Orchestration] Added Context-ID in Target Update#8977necusjz merged 17 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @atharvau, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses critical contextId handling issues in the workload-orchestration extension's target commands and updates documentation/packaging. The changes ensure proper Azure resource management workflows by fixing parameter requirements and schema definitions.
Key changes include:
- Fixed target update command to preserve contextId during round-trip operations by adding it to the schema
- Made context-id parameter required for target create operations
- Updated package version to 2.0.0 with enhanced documentation and metadata
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 2.0.0, status change to stable, and enhanced package description |
| _update.py | Added contextId to target schema and fixed provider namespace casing |
| _create.py | Made context-id parameter required and fixed provider namespace casing |
| README.md | Added comprehensive documentation about workload orchestration features |
| HISTORY.rst | Added changelog entry for version 2.0.0 |
Comments suppressed due to low confidence (2)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| options=["--description"], | ||
| arg_group="Properties", | ||
| help="Description of target", | ||
| required=True, |
| fmt=AAZStrArgFormat( | ||
| pattern="^[a-z0-9]([-a-z0-9]*[a-z0-9])?$", | ||
| ), | ||
|
|
|
[Release] Update index.json for extension [ workload-orchestration-2.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130825035&view=results |
Fix contextId handling in workload-orchestration target commands
Summary
This PR addresses critical issues with contextId parameter handling in the workload-orchestration extension's target create and update commands, ensuring proper Azure resource management workflows.
Changes Made
1. Added required context-id parameter to target create command
--context-idparameter as a required argument for target creation2. Fixed target update command contextId preservation
ObjectMissingRequiredProperty: contextIderrors_UpdateHelper._build_schema_target_read()methodTechnical Details
_update.pyto include contextId in the target resource schemaserialized_name="contextId")flags={"required": True})Testing
Test Evidence.pdf
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.